Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup yaml lint and local render target #7

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Setup yaml lint and local render target #7

merged 2 commits into from
Jan 4, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 4, 2024

Description of your changes

  • config
  • make target
  • github action
  • render target

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Before indentation fixes

✗ make yamllint
10:54:20 [ .. ] running yamllint
./apis/definition.yaml
  19:3      error    wrong indentation: expected 4 but found 2  (indentation)
  38:21     error    wrong indentation: expected 22 but found 20  (indentation)
  50:21     error    wrong indentation: expected 22 but found 20  (indentation)
  68:21     error    wrong indentation: expected 22 but found 20  (indentation)
  81:21     error    wrong indentation: expected 22 but found 20  (indentation)

./apis/composition.yaml
  28:13     error    wrong indentation: expected 14 but found 12  (indentation)
  33:13     error    wrong indentation: expected 14 but found 12  (indentation)
  37:9      error    wrong indentation: expected 10 but found 8  (indentation)

10:54:20 [FAIL]
make: *** [Makefile:78: yamllint] Error 1

@ytsarev ytsarev requested a review from a team January 4, 2024 09:55
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

1 similar comment
@haarchri
Copy link
Member

haarchri commented Jan 4, 2024

/test-examples

@haarchri haarchri mentioned this pull request Jan 4, 2024
Merged
3 tasks
ytsarev added 2 commits January 4, 2024 16:58
@ytsarev
Setup yaml lint and local render target
2acac5c 
* config
* make target
* github action
* render target

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Fix indentation according to the yamllint
7c29852 
Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

@ytsarev ytsarev merged commit 9aeacec into upbound:main Jan 4, 2024
2 checks passed
@ytsarev ytsarev deleted the yamllint branch January 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haarchri haarchri haarchri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytsarev @haarchri