Hide rule-based password expiry for users missing required scopes #7224
+79
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7224 +/- ##
=======================================
Coverage 32.32% 32.32%
=======================================
Files 42 42
Lines 897 897
Branches 221 216 -5
=======================================
Hits 290 290
Misses 557 557
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. |
features/admin.validation.v1/constants/validation-config-constants.ts
Outdated
Show resolved
Hide resolved
...nsole/java/org.wso2.identity.apps.console.server.feature/resources/deployment.config.json.j2
Show resolved
Hide resolved
...nsole/java/org.wso2.identity.apps.console.server.feature/resources/deployment.config.json.j2
Outdated
Show resolved
Hide resolved
…sed-password-expiry
PasinduYeshan
commented
Jan 2, 2025
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
pavinduLakshan
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The initial plan was to modify the token issuance logic to include these missing scopes in the console user token. However, this approach was revised. Instead of requiring these scopes, we decided to hide rule-based password expiry functionality for users without these permissions.
Screen.Recording.2024-12-19.at.10.13.58.mov
Related Issues
Related PRs
Checklist
Security checks