Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rule-based password expiry for users missing required scopes #7224

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Hide rule-based password expiry for users missing required scopes #7224

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2248420
Disable rule based password expiry for users missing required scopes
PasinduYeshan Dec 18, 2024
1d32c9f
Fix handle update method
PasinduYeshan Dec 19, 2024
36632b6
Merge remote-tracking branch 'upstream/master' into migration/rule-ba…
PasinduYeshan Dec 19, 2024
6b37873
Introduce ruleBasedPasswordExpiry feature config
PasinduYeshan Jan 2, 2025
fe406f2
Merge remote-tracking branch 'upstream/master' into migration/rule-ba…
PasinduYeshan Jan 2, 2025
4f2a110
Refactor
PasinduYeshan Jan 2, 2025
058e4a4
add admin.core to changeset
PasinduYeshan Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/lemon-pets-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@wso2is/admin.validation.v1": patch
"@wso2is/console": patch
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
---

Disable rule based password expiry for users without required scopes
4 changes: 1 addition & 3 deletions apps/console/src/public/deployment.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,9 +732,7 @@
"console:loginAndRegistration"
],
"read": [
"internal_governance_view",
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
"internal_group_mgt_view",
"internal_role_mgt_view"
"internal_governance_view"
],
"update": [
"internal_config_update",
Expand Down
8 changes: 8 additions & 0 deletions features/admin.validation.v1/constants/validation-config-constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ export class ValidationConfigConstants {
PASSWORD_MIN_VALUE: 5
};

/**
* These scopes are checked to determine whether to display the new rule-based password expiry configuration UI.
* If these scopes are not available, legacy password expiry configuration will be shown for backward compatibility.
*/
public static readonly RULE_BASED_PASSWORD_EXPIRY_REQUIRED_SCOPES: string[] = [
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
"internal_role_mgt_view",
"internal_group_mgt_view"
];
}

/**
Expand Down
22 changes: 16 additions & 6 deletions features/admin.validation.v1/pages/validation-config-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ export const ValidationConfigEditPage: FunctionComponent<MyAccountSettingsEditPa
state?.config?.ui?.isPasswordInputValidationEnabled);
const disabledFeatures: string[] = useSelector((state: AppState) =>
state?.config?.ui?.features?.loginAndRegistration?.disabledFeatures);
const isRuleBasedPasswordExpiryDisabled: boolean = disabledFeatures?.includes("ruleBasedPasswordExpiry");
const featureConfig: FeatureConfigInterface = useSelector((state: AppState) => state?.config?.ui?.features);

const [ isSubmitting, setSubmitting ] = useState<boolean>(false);
Expand Down Expand Up @@ -137,6 +136,10 @@ export const ValidationConfigEditPage: FunctionComponent<MyAccountSettingsEditPa
const [ legacyPasswordPolicies, setLegacyPasswordPolicies ] = useState<ConnectorPropertyInterface[]>([]);

const isReadOnly: boolean = !useRequiredScopes(featureConfig?.governanceConnectors?.scopes?.update);
const hasScopesForRuleBasedPasswordExpiry: boolean =
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
useRequiredScopes(ValidationConfigConstants.RULE_BASED_PASSWORD_EXPIRY_REQUIRED_SCOPES);
const isRuleBasedPasswordExpiryDisabled: boolean = disabledFeatures?.includes("ruleBasedPasswordExpiry")
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
|| !hasScopesForRuleBasedPasswordExpiry;

const {
data: passwordHistoryCountData,
Expand Down Expand Up @@ -600,14 +603,21 @@ export const ValidationConfigEditPage: FunctionComponent<MyAccountSettingsEditPa
): void => {
if (hasPasswordExpiryRuleErrors) return;

const processedFormValues: ValidationFormInterface = {
let processedFormValues: ValidationFormInterface = {
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
...values,
passwordExpiryEnabled: passwordExpiryEnabled,
passwordExpiryRules: processPasswordExpiryRules(),
passwordExpirySkipFallback: passwordExpirySkipFallback,
passwordExpiryTime: defaultPasswordExpiryTime
passwordExpiryEnabled: passwordExpiryEnabled
};

if (!isRuleBasedPasswordExpiryDisabled) {
processedFormValues = {
...values,
passwordExpiryEnabled: passwordExpiryEnabled,
PasinduYeshan marked this conversation as resolved.
Show resolved Hide resolved
passwordExpiryRules: processPasswordExpiryRules(),
passwordExpirySkipFallback: passwordExpirySkipFallback,
passwordExpiryTime: defaultPasswordExpiryTime
};
}

const updatePasswordPolicies: Promise<void> = serverConfigurationConfig.processPasswordPoliciesSubmitData(
processedFormValues,
!isPasswordInputValidationEnabled
Expand Down
Loading