compose: Enforce max topic/content length by code points, following API #1239
+171
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the same comment where we check the content length: if (textNormalized.length > kMaxMessageLengthCodePoints) and it applies here, too; the API doc on max_topic_length in /register also says it's in Unicode code points: https://zulip.com/api/register-queue And give our max-topic-length variable a more descriptive name, again like we do with kMaxMessageLengthCodePoints.
With zulip#996, these tests will have to start checking for separate per-platform flavors of alert dialog. Best if they all do so through this one codepath.
PIG208
reviewed
Jan 3, 2025
| @@ -95,6 +95,23 @@ void main() { | |||
| ..url.path.equals('/api/v1/users/me/${narrow.streamId}/topics'); | |||
| } | |||
|
|
|||
| /// Set the content input's text to [content], using [WidgetTester.enterText]. | |||
| Future<void> enterContent(WidgetTester tester, { | |||
| required ChannelNarrow narrow, | |||
There was a problem hiding this comment.
Looks like this is unused. For entering content, just having await tester.enterText(contentInputFinder, content); should be fine.
| /// is more expensive than getting the number of UTF-16 code units | ||
| /// ([String.length]), so we avoid it when the result definitely won't exceed | ||
| /// [maxLengthUnicodeCodePoints]. | ||
| int? get lengthUnicodeCodePointsIfLong => _lengthUnicodeCodePointsIfLong; |
There was a problem hiding this comment.
What if we maintain the length internally, and expose only a method that tests if the content is too long? We already have access to the length limit via maxLengthUnicodeCodePoints and hiding this cache might simplify the checks a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238.
Done by computing
String.runes(the number of Unicode code points) unless we know that the result can't exceed the threshold number of code points. In particular, we don't compute it unlessString.length(the number of UTF-16 code units) exceeds the threshold number of code points.